fix: Apps preventing join actions not showing any error #35332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1c2a35f The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tiagoevanp
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35332 +/- ##
========================================
Coverage 59.67% 59.67%
========================================
Files 2826 2826
Lines 68313 68313
Branches 15134 15134
========================================
Hits 40764 40764
Misses 24937 24937
Partials 2612 2612
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Tests will be covered in another PR |
MarcosSpessatto
suggested changes
Mar 6, 2025
…et.Chat into fix/app-preventing-error
Contributor
|
gabriellsh
previously requested changes
Mar 14, 2025
…et.Chat into fix/app-preventing-error
MarcosSpessatto
previously approved these changes
Mar 17, 2025
…et.Chat into fix/app-preventing-error
tiagoevanp
force-pushed
the
fix/app-preventing-error
branch
from
1cbe906 to
4a81fe1
Compare
tassoevan
approved these changes
Mar 20, 2025
tassoevan
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Preview Public Channel authorization is not in the user permissions group and an app is preventing the same user to join, the UI should dispatch a toast error message with the app reason.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SUP-742
CORE-957